lkml.org 
[lkml]   [2014]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 076/110] target: Set CMD_T_ACTIVE bit for Task Management Requests
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Nicholas Bellinger <nab@linux-iscsi.org>

    commit f15e9cd910c4d9da7de43f2181f362082fc45f0f upstream.

    This patch fixes a bug where se_cmd descriptors associated with a
    Task Management Request (TMR) where not setting CMD_T_ACTIVE before
    being dispatched into target_tmr_work() process context.

    This is required in order for transport_generic_free_cmd() ->
    transport_wait_for_tasks() to wait on se_cmd->t_transport_stop_comp
    if a session reset event occurs while an ABORT_TASK is outstanding
    waiting for another I/O to complete.

    Cc: Thomas Glanzmann <thomas@glanzmann.de>
    Cc: Charalampos Pournaris <charpour@gmail.com>
    Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/target/target_core_transport.c | 6 ++++++
    1 file changed, 6 insertions(+)

    --- a/drivers/target/target_core_transport.c
    +++ b/drivers/target/target_core_transport.c
    @@ -2868,6 +2868,12 @@ static void target_tmr_work(struct work_
    int transport_generic_handle_tmr(
    struct se_cmd *cmd)
    {
    + unsigned long flags;
    +
    + spin_lock_irqsave(&cmd->t_state_lock, flags);
    + cmd->transport_state |= CMD_T_ACTIVE;
    + spin_unlock_irqrestore(&cmd->t_state_lock, flags);
    +
    INIT_WORK(&cmd->work, target_tmr_work);
    queue_work(cmd->se_dev->tmr_wq, &cmd->work);
    return 0;



    \
     
     \ /
      Last update: 2014-06-28 21:21    [W:4.244 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site