Messages in this thread | | | From | "Luck, Tony" <> | Subject | RE: [PATCH v3 4/9] ACPI, x86: Extended error log driver for x86 platform | Date | Fri, 27 Jun 2014 20:43:14 +0000 |
| |
>> There's a logbuf_lock in printk. If logbuf_lock is held by other cpu, >> it'll lead to an infinity spin here. Isn't it? > > Yes, but we want to take the risk and print something out before the > machine dies instead of waiting to get into printk-safe context first > and maybe corrupt state.
Not all machine checks are fatal - it would be bad for us to go into an infinite spin instead of executing the recovery code.
> Besides, there's work currently going on to make printk safe in atomic > context so...
Good - we need this.
-Tony
| |