lkml.org 
[lkml]   [2014]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pinctrl: pinctrl-st.c: Cleaning up values that are never used
Hi Rickard

On 06/26/2014 03:44 PM, Rickard Strandqvist wrote:
> Remove variable that are never used
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/pinctrl/pinctrl-st.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 1bd6363bc9..d3bd687 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1178,9 +1178,7 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
> const __be32 *list;
> struct property *pp;
> struct st_pinconf *conf;
> - phandle phandle;
> struct device_node *pins;
> - u32 pin;
> int i = 0, npins = 0, nr_props;
>
> pins = of_get_child_by_name(np, "st,pins");
> @@ -1218,8 +1216,8 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
> conf = &grp->pin_conf[i];
>
> /* bank & offset */
> - phandle = be32_to_cpup(list++);
> - pin = be32_to_cpup(list++);
> + be32_to_cpup(list++);
> + be32_to_cpup(list++);
> conf->pin = of_get_named_gpio(pins, pp->name, 0);
> conf->name = pp->name;
> grp->pins[i] = conf->pin;

Acked-by: Patrice Chotard <patrice.chotard@st.com>

Thanks


\
 
 \ /
  Last update: 2014-06-27 09:41    [W:0.073 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site