Messages in this thread | | | Date | Fri, 27 Jun 2014 11:12:59 -0400 | From | Boris Ostrovsky <> | Subject | Re: [GIT PULL] 2 RAS fixes for 3.17, refreshed |
| |
On 06/27/2014 11:01 AM, Borislav Petkov wrote: > On Tue, Jun 24, 2014 at 09:27:01AM -0400, Konrad Rzeszutek Wilk wrote: >> Isn't that one a regression that was introduced in 3.16? > Hrrm, BorisO, you said misc_register would often fail in xen, is that > correct? Because if so, we added the error check to misc_register in > 3.16 so the mcheck_init_device fix would have to go in now.
Yes, it fails because xen_late_init_mcelog() registers /dev/mcelog and (I think) it happens before mcheck_init_device().
In other words, misc_register() expected to fail in mcheck/mce.c on (privileged?) PV guests (provided right CONFIG_XEN_* is set).
-boris
| |