Messages in this thread | | | Date | Fri, 27 Jun 2014 10:11:42 +0800 | Subject | Re: [PATCH v3] arch/score/include/uapi/asm/ptrace.h: Remove the macros which not be used currently | From | Lennox Wu <> |
| |
Acked-by: Lennox Wu <lennox.wu@gmail.com>
2014-06-27 7:28 GMT+08:00 Chen Gang <gang.chen.5i5j@gmail.com>: > > > On 06/27/2014 05:56 AM, David Rientjes wrote: >> On Thu, 26 Jun 2014, Chen Gang wrote: >> >>> 'COUNTER' and other same kind macros are too common to use, and easy to >>> get conflict with other modules. >>> >>> At present, they are not used, so it is OK to simply remove them. And the >>> related warning (allmodconfig with score): >>> >>> CC [M] drivers/md/raid1.o >>> In file included from drivers/md/raid1.c:42:0: >>> drivers/md/bitmap.h:93:0: warning: "COUNTER" redefined >>> #define COUNTER(x) (((bitmap_counter_t) x) & COUNTER_MAX) >>> ^ >>> In file included from ./arch/score/include/asm/ptrace.h:4:0, >>> from include/linux/sched.h:31, >>> from include/linux/blkdev.h:4, >>> from drivers/md/raid1.c:36: >>> ./arch/score/include/uapi/asm/ptrace.h:13:0: note: this is the location of the previous definition >>> #define COUNTER 38 >>> >>> >>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> >> >> Acked-by: David Rientjes <rientjes@google.com> >> > > OK, thanks. And also thank all of you for your discussions. > > Thanks. > -- > Chen Gang > > Open, share, and attitude like air, water, and life which God blessed
| |