Messages in this thread | | | Subject | Re: [PATCH] ecryptfs: Drop cast | From | Joe Perches <> | Date | Thu, 26 Jun 2014 11:58:53 -0700 |
| |
On Fri, 2014-06-27 at 00:12 +0530, Himangi Saraogi wrote: > This patch does away with casts on void * as they are unnecessary. [] > diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c [] > @@ -53,7 +53,7 @@ static void unlock_dir(struct dentry *dir) > > static int ecryptfs_inode_test(struct inode *inode, void *lower_inode) > { > - if (ecryptfs_inode_to_lower(inode) == (struct inode *)lower_inode) > + if (ecryptfs_inode_to_lower(inode) == lower_inode) > return 1; > return 0; > }
True, but perhaps this should be
{ return ecryptfs_inode_to_lower(inode) == lower_inode; }
| |