lkml.org 
[lkml]   [2014]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ecryptfs: Drop cast
From
Date
On Fri, 2014-06-27 at 00:12 +0530, Himangi Saraogi wrote:
> This patch does away with casts on void * as they are unnecessary.
[]
> diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
[]
> @@ -53,7 +53,7 @@ static void unlock_dir(struct dentry *dir)
>
> static int ecryptfs_inode_test(struct inode *inode, void *lower_inode)
> {
> - if (ecryptfs_inode_to_lower(inode) == (struct inode *)lower_inode)
> + if (ecryptfs_inode_to_lower(inode) == lower_inode)
> return 1;
> return 0;
> }

True, but perhaps this should be

{
return ecryptfs_inode_to_lower(inode) == lower_inode;
}





\
 
 \ /
  Last update: 2014-06-26 21:21    [W:0.027 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site