lkml.org 
[lkml]   [2014]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/22] enic: Use pci_zalloc_consistent


On Mon, 23 Jun 2014, Joe Perches wrote:

> Remove the now unnecessary memset too.
>
> Signed-off-by: Joe Perches <joe@perches.com>

Looks good, thanks
Acked-by: Govindarajulu Varadarajan <_govind@gmx.com>

> ---
> drivers/net/ethernet/cisco/enic/vnic_dev.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/cisco/enic/vnic_dev.c b/drivers/net/ethernet/cisco/enic/vnic_dev.c
> index e86a45c..8a4799c 100644
> --- a/drivers/net/ethernet/cisco/enic/vnic_dev.c
> +++ b/drivers/net/ethernet/cisco/enic/vnic_dev.c
> @@ -432,14 +432,12 @@ int vnic_dev_fw_info(struct vnic_dev *vdev,
> int err = 0;
>
> if (!vdev->fw_info) {
> - vdev->fw_info = pci_alloc_consistent(vdev->pdev,
> - sizeof(struct vnic_devcmd_fw_info),
> - &vdev->fw_info_pa);
> + vdev->fw_info = pci_zalloc_consistent(vdev->pdev,
> + sizeof(struct vnic_devcmd_fw_info),
> + &vdev->fw_info_pa);
> if (!vdev->fw_info)
> return -ENOMEM;
>
> - memset(vdev->fw_info, 0, sizeof(struct vnic_devcmd_fw_info));
> -
> a0 = vdev->fw_info_pa;
> a1 = sizeof(struct vnic_devcmd_fw_info);
>
> --
> 1.8.1.2.459.gbcd45b4.dirty
>
>


\
 
 \ /
  Last update: 2014-06-26 09:01    [W:0.647 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site