Messages in this thread | | | Date | Thu, 26 Jun 2014 09:51:44 +0800 | Subject | Re: [PATCH 2/2] staging: wlan-ng/hfa384x_usb.c: remove return statements for void function | From | Cheng-Wei Lee <> |
| |
Hi Joe,
Thanks for your kindly reply. I'll submit patch again.
Many thanks, Quentin
2014-06-26 8:09 GMT+08:00, Joe Perches <joe@perches.com>: > On Wed, 2014-06-25 at 23:35 +0800, Cheng-Wei Lee wrote: >> This patch fixes the following checkpatch.pl issues in hfa384x_usb.c: >> WARNING: Missing a blank line after declarations > > Still has a mismatch between subject and code > >> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c > [] >> @@ -3533,7 +3533,7 @@ static void hfa384x_usbin_rx(wlandevice_t >> *wlandev, struct sk_buff *skb) >> } >> >> done: >> - return; >> + pr_debug("hfa384x_usbin_rx: done\n"); > > I suggest you just leave the return, > > Any checkpatch suggestion this was needed was a false > positive that should be resolved by this patch: > > http://article.gmane.org/gmane.linux.kernel/1728891 > > >
| |