lkml.org 
[lkml]   [2014]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] tcp: fix setting csum_start in tcp_gso_segment
From
From: Dave Jones <davej@redhat.com>
Date: Wed, 25 Jun 2014 10:10:52 -0400

> On Tue, Jun 24, 2014 at 09:17:25PM -0700, Linus Torvalds wrote:
> > On Tue, Jun 24, 2014 at 9:03 PM, Tom Herbert <therbert@google.com> wrote:
> > >
> > > It looks like a likely culprit is that SKB_GSO_CB()->csum_start is
> > > not set correctly when doing non-scatter gather. We are using
> > > offset as opposed to doffset.
> > >
> > > Reported-by: Dave Jones <davej@redhat.com>
> >
> > DaveJ, I think you triggered this in five minutes on your box, and I
> > don't recall seeing anybody else reporting the oops (and google
> > doesn't find anything in the last month). So it's presumably somewhat
> > hw-specific. Does this fix the problem?
>
> It's survived routing ~1GB of packets overnight, so I'd call this good.

Tom, please adjust the Subject line as suggested by Eric Dumazet and add
a Tested-by: for Dave.

Thanks!


\
 
 \ /
  Last update: 2014-06-25 21:41    [W:0.062 / U:0.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site