Messages in this thread | | | Date | Wed, 25 Jun 2014 11:27:21 -0700 | Subject | Re: [PATCH 1/1] fs/omfs/inode.c: replace count*size kzalloc by kcalloc | From | Linus Torvalds <> |
| |
On Wed, Jun 25, 2014 at 11:17 AM, Fabian Frederick <fabf@skynet.be> wrote: > kcalloc manages count*sizeof overflow.
As far as I can tell, any overflow has happened long before, in
bitmap_size = DIV_ROUND_UP(sbi->s_num_blocks, 8);
where 'sbi->s_num_blocks' i san u64, and 'bitmap_size' is an 'int'.
I don't think the patch is necessarily a bad thing, but I think it might be more important to sanity-check that part instead.
Linus
| |