Messages in this thread | | | Date | Wed, 25 Jun 2014 14:27:01 +0200 | From | Paolo Bonzini <> | Subject | Re: [PATCH] arch: x86: kvm: x86.c: Cleaning up variable is set more than once |
| |
Il 25/06/2014 14:25, Rickard Strandqvist ha scritto: > A struct member variable is set to the same value more than once > > This was found using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> > --- > arch/x86/kvm/x86.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index f32a025..0f48eb7 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -4730,7 +4730,6 @@ static void emulator_set_segment(struct x86_emulate_ctxt *ctxt, u16 selector, > if (desc->g) > var.limit = (var.limit << 12) | 0xfff; > var.type = desc->type; > - var.present = desc->p; > var.dpl = desc->dpl; > var.db = desc->d; > var.s = desc->s; >
Thanks, applying this patch.
Paolo
| |