lkml.org 
[lkml]   [2014]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v8 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.
From
From: Iyappan Subramanian <isubramanian@apm.com>
Date: Fri, 20 Jun 2014 16:18:16 -0700

> This patch adds network driver for APM X-Gene SoC ethernet.
>
> Signed-off-by: Iyappan Subramanian <isubramanian@apm.com>
> Signed-off-by: Ravi Patel <rapatel@apm.com>
> Signed-off-by: Keyur Chudgar <kchudgar@apm.com>

I really don't like how you handle the hardware descriptors in this
driver.

You copy back and forth between a software format and the hardware
format. That's extremely wasteful and will hurt performance.

Just use the raw format throughout, you can extract the fields when
you need them.

You also make two passes when building a hardware descriptor:

1) write the values
2) endian swap

This means you make three memory accesses on every 64-bit word
in every descriptor you setup, this is really inefficient.

You should just byte swap them in-situ as you build the raw
descriptors.


\
 
 \ /
  Last update: 2014-06-25 08:21    [W:0.129 / U:0.952 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site