Messages in this thread | | | Date | Wed, 25 Jun 2014 10:54:47 +0100 | From | Lee Jones <> | Subject | Re: [PATCH] pwm-backlight: use devm_gpiod_get_optional() |
| |
> Make use of the new devm_gpiod_get_optional() to simplify the probe > code. > > Signed-off-by: Alexandre Courbot <acourbot@nvidia.com> > --- > drivers/video/backlight/pwm_bl.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-)
Looks good. Applied, thanks.
> diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c > index 38ca88bc5c3e..d1e0a7c6cac7 100644 > --- a/drivers/video/backlight/pwm_bl.c > +++ b/drivers/video/backlight/pwm_bl.c > @@ -245,13 +245,10 @@ static int pwm_backlight_probe(struct platform_device *pdev) > pb->dev = &pdev->dev; > pb->enabled = false; > > - pb->enable_gpio = devm_gpiod_get(&pdev->dev, "enable"); > + pb->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable"); > if (IS_ERR(pb->enable_gpio)) { > ret = PTR_ERR(pb->enable_gpio); > - if (ret == -ENOENT) > - pb->enable_gpio = NULL; > - else > - goto err_alloc; > + goto err_alloc; > } > > /*
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |