lkml.org 
[lkml]   [2014]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] DRBG: simplify ordering of linked list in drbg_ctr_df
On Mon, Jun 23, 2014 at 09:11:29AM +0200, Stephan Mueller wrote:
> As reported by a static code analyzer, the code for the ordering of
> the linked list can be simplified.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Stephan Mueller <smueller@chronox.de>
> ---
> crypto/drbg.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/crypto/drbg.c b/crypto/drbg.c
> index faaa2ce..99fa8f8 100644
> --- a/crypto/drbg.c
> +++ b/crypto/drbg.c
> @@ -516,13 +516,13 @@ static int drbg_ctr_df(struct drbg_state *drbg,
> S2.next = addtl;
>
> /*
> - * splice in addtl between S2 and S4 -- we place S4 at the end of the
> - * input data chain
> + * Splice in addtl between S2 and S4 -- we place S4 at the end
> + * of the input data chain. As this code is only triggered when
> + * addtl is not NULL, no NULL checks are necessary.
> */
> tempstr = addtl;
> - for (; NULL != tempstr; tempstr = tempstr->next)
> - if (NULL == tempstr->next)
> - break;
> + while (tempstr->next)
> + tempstr = tempstr->next;
> tempstr->next = &S4;

This is still broken.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


\
 
 \ /
  Last update: 2014-06-25 11:41    [W:0.147 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site