lkml.org 
[lkml]   [2014]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [RFC PATCH 0/3] Mark literal strings in __init / __exit code
    From
    On 25 June 2014 09:48, Joe Perches <joe@perches.com> wrote:
    > On Wed, 2014-06-25 at 09:35 +0200, Rasmus Villemoes wrote:
    >> Speaking of dangling pointers: A similar disaster would happen if some
    >> code containing pi_* calls gets copy-pasted to some non-__init
    >> function.
    >
    > This is my biggest issue with adding these new,
    > somewhat obscure macros.

    modpost will handle these cases.

    >> Could checkpatch learn to warn about calling these functions
    >> from the wrong context?
    >
    > It's not possible. checkpatch works on patch chunks.
    > Any patch chunk may not contain the function attributes.

    checkpatch.pl -f might detect them, though :/

    Thanks,
    Mathias


    \
     
     \ /
      Last update: 2014-06-25 11:21    [W:4.569 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site