Messages in this thread | | | Date | Tue, 24 Jun 2014 18:03:22 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH] slub: fix off by one in number of slab tests |
| |
On Tue, 24 Jun 2014, Joonsoo Kim wrote:
> min_partial means minimum number of slab cached in node partial > list. So, if nr_partial is less than it, we keep newly empty slab > on node partial list rather than freeing it. But if nr_partial is > equal or greater than it, it means that we have enough partial slabs > so should free newly empty slab. Current implementation missed > the equal case so if we set min_partial is 0, then, at least one slab > could be cached. This is critical problem to kmemcg destroying logic > because it doesn't works properly if some slabs is cached. This patch > fixes this problem. > > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Acked-by: David Rientjes <rientjes@google.com>
Needed for 3.16 to fix commit 91cb69620284 ("slub: make dead memcg caches discard free slabs immediately").
| |