lkml.org 
[lkml]   [2014]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Alan, can you revisit a patch you authored please?
On Mon, 23 Jun 2014 09:53:45 +0100
Lee Jones <lee.jones@linaro.org> wrote:

> Hi Alan,
>
> I'm looking at a patch you wrote which can be foudn below at [1]. Are
> you sure it's correct to ignore i.e not return -ENOMEM from
> platform_device_add_data() in pcf50633_probe()? I believe if
> platform_device_add_data() returns an error we should
> platform_device_put() and return immediately. Can you tell me if you
> agree. If you don't, would you mind explaining to me why please?

I made the change to maximise the chance of things booting up ok, but I
agree, its a pointless exercise. If we fail to add the data we should
just chuck it.

Alan


\
 
 \ /
  Last update: 2014-06-24 15:01    [W:0.029 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site