lkml.org 
[lkml]   [2014]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/11] usb: dwc2/gadget: do not call disconnect method in pullup
    Date
    From: Marek Szyprowski <m.szyprowski@samsung.com>

    This leads to potential spinlock recursion in composite framework, other
    udc drivers also don't call it directly from pullup method.

    Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
    Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
    ---
    drivers/usb/dwc2/gadget.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
    index 2220882..def4900 100644
    --- a/drivers/usb/dwc2/gadget.c
    +++ b/drivers/usb/dwc2/gadget.c
    @@ -2945,7 +2945,6 @@ static int s3c_hsotg_pullup(struct usb_gadget *gadget, int is_on)
    s3c_hsotg_phy_enable(hsotg);
    s3c_hsotg_core_init(hsotg);
    } else {
    - s3c_hsotg_disconnect(hsotg);
    s3c_hsotg_phy_disable(hsotg);
    }

    --
    1.9.1


    \
     
     \ /
      Last update: 2014-06-23 10:41    [W:3.977 / U:0.752 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site