Messages in this thread | | | Date | Mon, 23 Jun 2014 15:41:34 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH v8 4/4] printk: allow increasing the ring buffer depending on the number of CPUs |
| |
On Wed, 18 Jun 2014 13:45:37 -0700 "Luis R. Rodriguez" <mcgrof@do-not-panic.com> wrote:
> ... > > If an increase is required the ring buffer is increased to > + the next power of 2 that can fit both the minimum kernel ring buffer > + (LOG_BUF_SHIFT) plus the additional worst case CPU contributions. > > ... > > + log_buf_len_update(cpu_extra + __LOG_BUF_LEN); > +}
I'd have expected
total_cpu_space = minimum-per-cpu-len * nr_possible_cpus; log_buf_len = max(__LOG_BUF_LEN, total_cpu_space)
but here you added __LOG_BUF_LEN to total_cpu_space and I cannot work out why.
| |