lkml.org 
[lkml]   [2014]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v8 4/4] printk: allow increasing the ring buffer depending on the number of CPUs
    On Wed, 18 Jun 2014 13:45:37 -0700 "Luis R. Rodriguez" <mcgrof@do-not-panic.com> wrote:

    > ...
    >
    > If an increase is required the ring buffer is increased to
    > + the next power of 2 that can fit both the minimum kernel ring buffer
    > + (LOG_BUF_SHIFT) plus the additional worst case CPU contributions.
    >
    > ...
    >
    > + log_buf_len_update(cpu_extra + __LOG_BUF_LEN);
    > +}

    I'd have expected

    total_cpu_space = minimum-per-cpu-len * nr_possible_cpus;
    log_buf_len = max(__LOG_BUF_LEN, total_cpu_space)

    but here you added __LOG_BUF_LEN to total_cpu_space and I cannot work
    out why.


    \
     
     \ /
      Last update: 2014-06-24 01:01    [W:4.157 / U:0.820 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site