Messages in this thread | | | Date | Mon, 23 Jun 2014 12:07:24 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 1/3] sched/fair: Disable runtime_enabled on dying rq |
| |
On Tue, Jun 17, 2014 at 05:24:10PM +0400, Kirill Tkhai wrote: > @@ -3790,6 +3803,12 @@ static void __maybe_unused unthrottle_offline_cfs_rqs(struct rq *rq) > cfs_rq->runtime_remaining = 1; > if (cfs_rq_throttled(cfs_rq)) > unthrottle_cfs_rq(cfs_rq); > + > + /* > + * Offline rq is schedulable till cpu is completely disabled > + * in take_cpu_down(), so we prevent new cfs throttling here. > + */ > + cfs_rq->runtime_enabled = 0;
Does it make sense to clear this before calling unthrottle_cfs_rq()? Just to make sure they're in the right order..
> } > }
| |