Messages in this thread | | | Date | Mon, 23 Jun 2014 11:42:03 +0200 | From | Uwe Kleine-König <> | Subject | Re: [patch 12/13] mm: memcontrol: rewrite charge API |
| |
On Mon, Jun 23, 2014 at 11:30:52AM +0200, Michal Hocko wrote: > On Mon 23-06-14 08:15:26, Uwe Kleine-König wrote: > > Hello, > > > > On Wed, Jun 18, 2014 at 04:40:44PM -0400, Johannes Weiner wrote: > > > The memcg charge API charges pages before they are rmapped - i.e. have > > > an actual "type" - and so every callsite needs its own set of charge > > > and uncharge functions to know what type is being operated on. Worse, > > > uncharge has to happen from a context that is still type-specific, > > > rather than at the end of the page's lifetime with exclusive access, > > > and so requires a lot of synchronization. > > > ... > > > > this patch made it into next-20140623 as 5e49555277df (mm: memcontrol: rewrite > > charge API) and it makes efm32_defconfig (ARCH=arm) fail with: > > > > CC mm/swap.o > > mm/swap.c: In function 'lru_cache_add_active_or_unevictable': > > mm/swap.c:719:2: error: implicit declaration of function 'TestSetPageMlocked' [-Werror=implicit-function-declaration] > > if (!TestSetPageMlocked(page)) { > > ^ > > cc1: some warnings being treated as errors > > scripts/Makefile.build:257: recipe for target 'mm/swap.o' failed > > make[3]: *** [mm/swap.o] Error 1 > > Makefile:1471: recipe for target 'mm/swap.o' failed > > > > imx_v4_v5_defconfig works, so probably the thing that makes > > efm32_defconfig fail is CONFIG_MMU=n. > > Fix is here: > http://marc.info/?l=linux-mm&m=140330132521104 Thanks for the link.
I have another problem that makes my machine fail to boot but at least this patch makes next compilable again for me.
Thanks Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |