lkml.org 
[lkml]   [2014]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] ARM: mvebu: rename ARM_ERRATA_753970
From
Date
On Mon, 2014-06-23 at 10:07 +0100, Russell King - ARM Linux wrote:
> On Mon, Jun 23, 2014 at 11:01:44AM +0200, Paul Bolle wrote:
> > Dropped the "if CACHE_PL310" fragments used in v1. No need to use "if
> > CACHE_L2X0" instead. Both CACHE_PL310 and CACHE_L2X0 will be
> > (indirectly) selected if MACH_ARMADA_375 or MACH_ARMADA_38X are set.
>
> Yes there is. We've recently seen the selection of CACHE_L2X0 be removed
> from platforms, while leaving the selection of the errata behind. The
> result is Kconfig warnings. My commit above ensures that this doesn't
> happen in the future by adding the proper dependencies onto those errata
> selects.

The entries I touched read (in summary):
config MACH_MVEBU_V7
bool
select CACHE_L2X0

config MACH_ARMADA_370
bool "Marvell Armada 370 boards" if ARCH_MULTI_V7
select MACH_MVEBU_V7
help
[...].

config MACH_ARMADA_375
bool "Marvell Armada 375 boards" if ARCH_MULTI_V7
select MACH_MVEBU_V7
help
[...].

So the choice I faced was between:
- using "select PL310_ERRATA_753970 if CACHE_L2X0": that matches all
current occurrences of "select PL310_ERRATA_*" but adds a superfluous
dependency on CACHE_L2X0
- using just "select PL310_ERRATA_753970": sufficient, but will break
if CACHE_L2X0 isn't selected through MACH_MVEBU_V7 anymore.

I chose to just "select PL310_ERRATA_753970" but adding "if CACHE_L2X0"
is fine with me too.

> Please do the same.

Will do later today.

Thanks,


Paul Bolle



\
 
 \ /
  Last update: 2014-06-23 12:21    [W:0.083 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site