Messages in this thread | | | Date | Mon, 23 Jun 2014 11:07:17 +0800 | From | Chen Gang <> | Subject | Re: [PATCH] arch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros |
| |
On 06/23/2014 12:28 AM, Guenter Roeck wrote: > On 06/22/2014 01:09 AM, Lennox Wu wrote: >> Hi Chen, >> Do you find other modules except device modules cause issues of >> compiling? >> The applications of Score are limited. Acutally, some errors never occur >> in the limited applications, for example, the conbination consists of >> Score and the timer of SuperH. I'm not sure we should handle this kind >> of error. >> If the rule is that we should make sure "all" modules can be compiled >> with Score, we will do it. >> However, we still thanks for your check. >> > > Other architectures don't care about buildability of allmodconfig or > allyesconfig > (arm is a good [or maybe bad] example), so it is for sure not mandatory. > On the other side, fixing such problems - especially when you have someone > doing it for you - may prevent problems down the road, so while not > mandatory > I consider it a useful goal to achieve. > > If there is a driver which doesn't make sense to build at all, such as > the SuperH > timer driver mentioned above, it can always be excluded from building > with Kconfig. > If that causes opposition for some reason, you can still ignore that it > fails > to build. >
Yeah, what Guenter said is fine to me.
Although allmodconfig is not mandatory, it is still a useful goal to achieve.
Thanks. -- Chen Gang
Open, share, and attitude like air, water, and life which God blessed
| |