lkml.org 
[lkml]   [2014]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] cxgb4: use dev_port to identify ports
From
From: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
Date: Sat, 21 Jun 2014 09:48:08 -0300

> Commit 3f85944fe207d0225ef21a2c0951d4946fc9a95d ("net: Add sysfs file
> for port number") introduce dev_port to network devices. cxgb4 adapters
> have multiple ports on the same PCI function, and used dev_id to
> identify those ports. That use was removed by commit
> 8c367fcbe6549195d2eb11e62bea233f811aad41 ("cxgb4: Do not set
> net_device::dev_id to VI index"), since dev_id should be used only when
> devices share the same MAC address.
>
> Using dev_port for cxgb4 allows different ports on the same PCI function
> to be identified.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>

You've made exactly zero effort to explain why the IPV6 issue carefully
explained in commit 8c367fcbe6549195d2eb11e62bea233f811aad41 no longer
applies.

As far as I can tell, it absolutely does, and therefore this change
here should not be made.

I'm not applying this patch, sorry.


\
 
 \ /
  Last update: 2014-06-23 02:41    [W:0.087 / U:3.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site