Messages in this thread Patch in this message | | | From | Jason Cooper <> | Subject | [PATCH] direct-io: squelch maybe-uninitialized warning in do_direct_IO() | Date | Sat, 21 Jun 2014 03:58:59 +0000 |
| |
The following warnings:
fs/direct-io.c: In function ‘__blockdev_direct_IO’: fs/direct-io.c:1011:12: warning: ‘to’ may be used uninitialized in this function [-Wmaybe-uninitialized] fs/direct-io.c:913:16: note: ‘to’ was declared here fs/direct-io.c:1011:12: warning: ‘from’ may be used uninitialized in this function [-Wmaybe-uninitialized] fs/direct-io.c:913:10: note: ‘from’ was declared here
are not necessary because dio_get_page() either fails, or sets both 'from' and 'to'.
Make the compiler happy so we can more easily detect legitimate warnings.
Signed-off-by: Jason Cooper <jason@lakedaemon.net> --- fs/direct-io.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/direct-io.c b/fs/direct-io.c index 98040ba388ac..c0a9854d2bc7 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c @@ -910,7 +910,8 @@ static int do_direct_IO(struct dio *dio, struct dio_submit *sdio, while (sdio->block_in_file < sdio->final_block_in_request) { struct page *page; - size_t from, to; + size_t from = 0; + size_t to = 0; page = dio_get_page(dio, sdio, &from, &to); if (IS_ERR(page)) { ret = PTR_ERR(page); -- 2.0.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |