Messages in this thread Patch in this message | | | From | Rasmus Villemoes <> | Subject | [PATCH] checkpatch.pl: Also suggest 'else if' when if follows brace | Date | Fri, 20 Jun 2014 22:04:25 +0200 |
| |
This might help a kernel hacker think twice before blindly adding a newline.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 010b18e..e1924eb 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3601,7 +3601,7 @@ sub process { # if should not continue a brace if ($line =~ /}\s*if\b/) { ERROR("TRAILING_STATEMENTS", - "trailing statements should be on next line\n" . + "trailing statements should be on next line (or did you mean 'else if'?)\n" . $herecurr); } # case and default should not have general statements after them -- 1.9.2
| |