lkml.org 
[lkml]   [2014]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: dgap: make dgap_found_board() return a brd pointer
On Fri, Jun 20, 2014 at 02:19:58PM +0900, Daeseok Youn wrote:
> - rc = dgap_found_board(pdev, ent->driver_data, dgap_numboards);
> - if (rc)
> + brd = dgap_found_board(pdev, ent->driver_data, dgap_numboards);
> + if (IS_ERR(brd))
> return rc;

return ERR_PTR(brd);


>
> - brd = dgap_board[dgap_numboards++];
> rc = dgap_firmware_load(pdev, ent->driver_data, brd);
> if (rc)
> goto cleanup_brd;
> @@ -617,6 +617,8 @@ static int dgap_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> brd->state = BOARD_READY;
> brd->dpastatus = BD_RUNNING;
>
> + dgap_board[dgap_numboards++] = brd;

You need to update the error handling of this function to remove the
reference do dgap_board[] as well.

> +
> return 0;
>

regards,
dan carpenter



\
 
 \ /
  Last update: 2014-06-20 12:01    [W:0.035 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site