Messages in this thread | | | Subject | Re: [PATCH 6/9] perf bench: futex: Replace --silent option with global --format | From | Davidlohr Bueso <> | Date | Thu, 19 Jun 2014 10:01:57 -0700 |
| |
On Thu, 2014-06-19 at 13:38 -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Jun 16, 2014 at 11:14:24AM -0700, Davidlohr Bueso escreveu: > > Using the already existing '--format simple' option in perf-bench > > is/should be equivalent to disabling any verbose output. Replace > > it and free up the -s option specific to the futex benchmark. > > Isn't this much longer?
It is, and to be honest I detest the whole --format option. But its already there and I really want to make use of global parameters in order to recycle options that are benchmark-specific. What I'd really like is to replace it with --silent and just have perf spit out the raw data (for scripting). But that would be too disruptive to users, imho. Does it matter? I dunno.
> I haven't seen any patch in this series wanting to use -s. > > Ingo, are you Ok with this? > > I.e. I'm just trying to be careful when changing existing cmd line args, > perhaps someone is used to this, who knows, and at least for me, > --silent is way, way more clear than '--format simple', that says > nothing to me.
If we can get away with it then lets.
Thanks, Davidlohr
| |