Messages in this thread | | | Date | Thu, 19 Jun 2014 15:02:02 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 5/5] perf tools: Add report.show-headers config file option |
| |
On Thu, Jun 19, 2014 at 09:56:44PM +0900, Namhyung Kim wrote: > Hi Jiri, > > 2014-06-19 (목), 13:41 +0200, Jiri Olsa: > > Adding report.show-headers config file option to setup > > the appearance of the columns headers. > > > > Currently columns headers are displayed by default, following > > lines in ~/.perfconfig file will disable that: > > > > [report] > > show-headers = true > > This also applies to perf top, right? And it's TUI-specific. So how > about calling it something like "tui.show-headers"?
ook
> > > [SNIP] > > @@ -35,6 +35,7 @@ struct symbol_conf symbol_conf = { > > .demangle = true, > > .cumulate_callchain = true, > > .symfs = "", > > + .show_headers = -1, > > Hmm.. why not just making it boolean and set it to true (like others)?
I need 'unset' value, otherwise I dont know if the config option was unset by user or not touched at all
jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |