lkml.org 
[lkml]   [2014]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 14/24] ARM64:ILP32: COMPAT_USE_64BIT_TIME is true for ILP32 tasks.
    On Sat, May 24, 2014 at 12:02:09AM -0700, Andrew Pinski wrote:
    > Since __kernel_long_t (time_t) is long long, we need to tell the rest
    > of kernel that we use 64bit time_t for compat when the task is not an
    > AARCH32 task. The reason why we check AARCH32 rather than ILP32 here
    > is because if we don't have AARCH32 compiled in (which is going to be
    > the common case due to AARCH32 requiring 4k pages).
    >
    > Thanks,
    > Andrew Pinski
    >
    > Signed-off-by: Andrew Pinski <apinski@cavium.com>
    > ---
    > arch/arm64/include/asm/compat.h | 3 +++
    > 1 files changed, 3 insertions(+), 0 deletions(-)
    >
    > diff --git a/arch/arm64/include/asm/compat.h b/arch/arm64/include/asm/compat.h
    > index 85f945c..c77fc0f 100644
    > --- a/arch/arm64/include/asm/compat.h
    > +++ b/arch/arm64/include/asm/compat.h
    > @@ -76,6 +76,9 @@ struct compat_timeval {
    > s32 tv_usec;
    > };
    >
    > +/* ILP32 uses 64bit time_t and not the above compat structures */
    > +#define COMPAT_USE_64BIT_TIME !is_a32_compat_task()

    Brackets.

    BTW, you could write is_ilp32_compat_task().

    --
    Catalin


    \
     
     \ /
      Last update: 2014-06-19 15:41    [W:8.992 / U:0.392 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site