lkml.org 
[lkml]   [2014]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/5] perf tools: Fix scrollbar refresh row index
    Date
    The ui_browser__gotorc function needs offset from 'y' member,
    so the row index has to begin with 0, which happens by accident
    in current code, because we display only one header line.

    The bug shows when we want to display more than 1 header lines
    like columns headers in following patches.

    Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
    Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Signed-off-by: Jiri Olsa <jolsa@kernel.org>
    ---
    tools/perf/ui/browser.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c
    index e6f96be..6792efb 100644
    --- a/tools/perf/ui/browser.c
    +++ b/tools/perf/ui/browser.c
    @@ -285,7 +285,7 @@ static void ui_browser__scrollbar_set(struct ui_browser *browser)
    {
    int height = browser->height, h = 0, pct = 0,
    col = browser->width,
    - row = browser->y - 1;
    + row = 0;

    if (browser->nr_entries > 1) {
    pct = ((browser->index * (browser->height - 1)) /
    --
    1.8.3.1


    \
     
     \ /
      Last update: 2014-06-19 14:21    [W:4.187 / U:0.348 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site