Messages in this thread |  | | Date | Wed, 18 Jun 2014 15:49:47 -0700 | | From | Greg KH <> | | Subject | Re: [PATCHv2]staging:rtl8192e:check return value of dev_skb_alloc |
| |
On Wed, Jun 18, 2014 at 06:23:00PM -0400, Nicholas Krause wrote: > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c > index 11e915e..fde17ff 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c > +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c > @@ -62,12 +62,15 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address, > > skb = dev_alloc_skb(frag_length + 4); > + if (!skb) > + return !rt_status; > memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev)); > tcb_desc = (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE); > tcb_desc->queue_index = TXCMD_QUEUE; > tcb_desc->bCmdOrInit = DESC_PACKET_TYPE_INIT; > tcb_desc->bLastIniPkt = bLastIniPkt; > - > > seg_ptr = skb->data; > for (i = 0; i < frag_length; i += 4) {
Again, always use checkpatch.pl before sending out patches...
|  |