lkml.org 
[lkml]   [2014]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] floppy: Neaten message logging
On Wed, 18 Jun 2014, Joe Perches wrote:

> Use a more current style to prefix "floppy: " on
> all messages.
>
> Convert DPRINT to emit at KERN_DEBUG.
>
> Other miscellaneous logging changes:
>
> o Add missing newline
> o Remove embedded "floppy" style prefixes

Why is this a good change?

[ ... ]
> if (!req) {
> - pr_info("floppy.c: no request in request_done\n");
> + pr_info("no request in request_done\n");

I think that in cases like this (and elsewhere where you are changing it
in your patch) the prefix is actually useful.

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2014-06-19 00:21    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog