lkml.org 
[lkml]   [2014]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 8/9] regulator: palmas: add driver data and modularize the probe
On Tuesday 17 June 2014 10:15 PM, Lee Jones wrote:
>> add driver data and modularize the probe.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>> drivers/mfd/palmas.c | 42 +--
>> drivers/regulator/palmas-regulator.c | 656 ++++++++++++++++++++--------------
>> 2 files changed, 395 insertions(+), 303 deletions(-)
>>
>> diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
> [...]
>
>> @@ -370,6 +334,8 @@ int palmas_ext_control_req_config(struct palmas *palmas,
>> int bit_pos;
>> int ret;
>>
>> + struct palmas_pmic_driver_data *pmic_ddata = palmas->pmic_ddata;
>> +
> Nit: I'd prefer the declarations to be grouped together, normally with
> the struct defines above the ints etc.

Ok. I will change this.

>
> [...]
>



\
 
 \ /
  Last update: 2014-06-18 07:41    [W:0.474 / U:0.952 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site