Messages in this thread | | | Date | Wed, 18 Jun 2014 10:23:25 +0530 | From | Keerthy <> | Subject | Re: [PATCH 8/9] regulator: palmas: add driver data and modularize the probe |
| |
On Tuesday 17 June 2014 10:15 PM, Lee Jones wrote: >> add driver data and modularize the probe. >> >> Signed-off-by: Keerthy <j-keerthy@ti.com> >> --- >> drivers/mfd/palmas.c | 42 +-- >> drivers/regulator/palmas-regulator.c | 656 ++++++++++++++++++++-------------- >> 2 files changed, 395 insertions(+), 303 deletions(-) >> >> diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c > [...] > >> @@ -370,6 +334,8 @@ int palmas_ext_control_req_config(struct palmas *palmas, >> int bit_pos; >> int ret; >> >> + struct palmas_pmic_driver_data *pmic_ddata = palmas->pmic_ddata; >> + > Nit: I'd prefer the declarations to be grouped together, normally with > the struct defines above the ints etc.
Ok. I will change this.
> > [...] >
| |