lkml.org 
[lkml]   [2014]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] hwmon: Driver for TI TMP103 temperature sensor
On Tue, Jun 17, 2014 at 05:11:05PM +0100, Mark Rutland wrote:
> On Tue, Jun 17, 2014 at 09:11:53AM +0100, Heiko Schocher wrote:
> > Driver for the TI TMP103.
> >
> > The TI TMP103 is similar to the TMP102. It differs from the TMP102
> > by having only 8 bit registers.
> >
> > Signed-off-by: Heiko Schocher <hs@denx.de>
> >
[ ... ]
> > +
> > +static const struct i2c_device_id tmp103_id[] = {
> > + { DRIVER_NAME, 0 },
>
> This seems to be used for compatible string matching. As such, I think
> it would make more sense to have the string in full here so as to
> discourage it from being changed arbitrarily in future.
>
Makes sense. Heiko, can you change that as well in v5 ?
It also simplifies adding another chip to the driver, should that
ever happen.

Thanks,
Guenter


\
 
 \ /
  Last update: 2014-06-18 02:41    [W:0.208 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site