lkml.org 
[lkml]   [2014]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.8 074/121] ip6_tunnel: fix potential NULL pointer dereference
    Date
    3.8.13.24 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Susant Sahani <susant@redhat.com>

    [ Upstream commit c8965932a2e3b70197ec02c6741c29460279e2a8 ]

    The function ip6_tnl_validate assumes that the rtnl
    attribute IFLA_IPTUN_PROTO always be filled . If this
    attribute is not filled by the userspace application
    kernel get crashed with NULL pointer dereference. This
    patch fixes the potential kernel crash when
    IFLA_IPTUN_PROTO is missing .

    Signed-off-by: Susant Sahani <susant@redhat.com>
    Acked-by: Thomas Graf <tgraf@suug.ch>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    net/ipv6/ip6_tunnel.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c
    index 78af3c7..2ce58fe 100644
    --- a/net/ipv6/ip6_tunnel.c
    +++ b/net/ipv6/ip6_tunnel.c
    @@ -1545,7 +1545,7 @@ static int ip6_tnl_validate(struct nlattr *tb[], struct nlattr *data[])
    {
    u8 proto;

    - if (!data)
    + if (!data || !data[IFLA_IPTUN_PROTO])
    return 0;

    proto = nla_get_u8(data[IFLA_IPTUN_PROTO]);
    --
    1.9.1


    \
     
     \ /
      Last update: 2014-06-18 00:21    [W:4.071 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site