Messages in this thread | | | Date | Tue, 17 Jun 2014 10:27:27 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH RESEND] libahci_platform: Fail when PHY required but PHY support disabled |
| |
On Tue, Jun 17, 2014 at 03:07:55PM +0300, Mikko Perttunen wrote: > ahci_platform_get_resources handles resource management for > platform AHCI drivers, including getting a possible PHY > from the device tree. Since not all drivers need a PHY, it > ignores -ENODEV and -ENOSYS from devm_get_phy. However, when > the PHY subsystem is mistakenly disabled, -ENOSYS can be > returned even when a PHY is needed. > > This patch modifies the -ENOSYS case to check if a "phys" > device tree node exists. If it exists, then clearly the PHY > subsystem is mistakenly disabled and the driver cannot work, > ahci_platform_get_resources will fail and propagate the error. > > Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
Applied to libata/for-3.17.
Thanks.
-- tejun
| |