lkml.org 
[lkml]   [2014]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] infiniband: Fixes memory leak in send_flowc
Date


> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma-owner@vger.kernel.org] On
> Behalf Of David Rientjes
> Sent: Monday, June 16, 2014 7:37 PM
> To: Nick Krause
> Cc: Steve Wise; swise@chelsio.com; roland@kernel.org; sean.hefty@intel.com;
> hal.rosenstock@gmail.com; linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] infiniband: Fixes memory leak in send_flowc
>
> On Mon, 16 Jun 2014, Nick Krause wrote:
>
> > That's true David,
> > I will resend this parch without the use of the pr_warn.
>
> There's no patch to resend if you don't use pr_warn(). kfree_skb(skb) is
> unnecessary if !skb, look at the first thing it checks:
>
> void kfree_skb(struct sk_buff *skb)
> {
> if (unlikely(!skb))
> return;
> ...
> }
>
> Thus, I don't see the memory leak you're referring to.

send_flowc() still needs to handle a NULL return from get_skb(). That is what the bug
report is addressing...

Steve.




\
 
 \ /
  Last update: 2014-06-17 16:41    [W:0.300 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site