Messages in this thread | | | Date | Tue, 17 Jun 2014 13:01:39 +0200 | From | Heiko Schocher <> | Subject | Re: [PATCH v4] hwmon: Driver for TI TMP103 temperature sensor |
| |
Hello Guenter
Am 17.06.2014 12:48, schrieb Guenter Roeck: > On 06/17/2014 01:11 AM, Heiko Schocher wrote: >> Driver for the TI TMP103. >> >> The TI TMP103 is similar to the TMP102. It differs from the TMP102 >> by having only 8 bit registers. >> >> Signed-off-by: Heiko Schocher <hs@denx.de> >> > [ ... ] >> +#define TMP103_CONF_SD (TMP103_CONF_M0 | TMP103_CONF_M1) > > Hello Heiko, > > I thought this needs to be TMP103_CONF_M1, but from the datasheet it looks > like it does not matter if M0 is set if M1 is set as well. Did you test it, > though, to make sure that it works ? I feel slightly uncomfortable with it.
Yes, i tested it on an imx6 based board. I see no issues ... but I can test it with "#define TMP103_CONF_SD TMP103_CONF_M1" and post a v5 with this setting if it works ...
bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
| |