lkml.org 
[lkml]   [2014]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: slicoss: Fix coding style issue
On Fri, Jun 13, 2014 at 10:04:35AM -0700, Greg KH wrote:
> On Fri, Jun 13, 2014 at 05:52:33PM +0200, Benedict Boerger wrote:
> > Fix a coding style issue found by checkpatch.pl.
> > Use ether_addr_copy instead of memcpy.
> >
> > Done to complete a eudyptula task.
> >
> > Signed-off-by: Benedict Boerger <benedict.boerger@cs.tu-dortmund.de>
> >
> > ---
> > drivers/staging/slicoss/slicoss.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> > index 48841e7..02807a3 100644
> > --- a/drivers/staging/slicoss/slicoss.c
> > +++ b/drivers/staging/slicoss/slicoss.c
> > @@ -1790,7 +1790,7 @@ static int slic_mcast_add_list(struct adapter *adapter, char *address)
> > if (mcaddr == NULL)
> > return 1;
> >
> > - memcpy(mcaddr->address, address, ETH_ALEN);
> > + ether_addr_copy(mcaddr->address, address);
> >
> > mcaddr->next = adapter->mcastaddrs;
> > adapter->mcastaddrs = mcaddr;
>
> Are you sure this is correct? It's not always a one-to-one replacement
> from what I have been told.

I hate this checkpatch.pl warning because it just encourages people to
add bugs.

regards,
dan carpenter



\
 
 \ /
  Last update: 2014-06-16 10:41    [W:0.068 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site