Messages in this thread | | | Date | Mon, 16 Jun 2014 20:21:20 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH] include: kernel.h: rewrite min3, max3 and clamp using min and max |
| |
On Mon, 16 Jun 2014 16:54:32 -0700 (PDT) David Rientjes <rientjes@google.com> wrote:
> > > On linux-next, allyesconfig has a 0.0001% savings as a result of the > patch, but I'd be worried about the extra temp variable it allocates on > the stack that is evident in the mm/slab.c disassembly unless all cases > can be audited to show that we're not potentially deep.
A 0.0001% change means it's not worth changing, and we may be able to mark this up as a fluke in Michal's results.
I'll give it a try on my 4.6.3 compiler.
-- Steve
> > text data bss dec hex filename > 108573045 23488016 51580928 183641989 af22785 vmlinux.before > 108572908 23488016 51580928 183641852 af226fc vmlinux.after
| |