lkml.org 
[lkml]   [2014]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v4 2/2] mmc: sdhci: Replace host->mmc with mmc where possible
    From
    On 16 June 2014 01:23, Ulf Hansson <ulf.hansson@linaro.org> wrote:
    > On 13 June 2014 19:13, Markus Mayer <markus.mayer@linaro.org> wrote:
    >> After the switch to the MMC core regulator infrastucture, we already
    >> have a local "mmc" pointer in various functions. There is no longer a
    >> need to access the data structure via host->mmc.
    >>
    >> Signed-off-by: Markus Mayer <markus.mayer@linaro.org>
    >> Reviewed-by: Matt Porter <mporter@linaro.org>
    >
    > Could you run checkpatch? There were some warnings to handle.

    You're right. There are several warnings regarding wrapped strings.
    However, those warnings are unrelated to my changes. The wrapped
    strings exist in current code.

    See for instance:
    https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/mmc/host/sdhci.c?id=refs/tags/v3.16-rc1#n1730

    I don't think I should intermix my "host->mmc to mmc" replacement
    patch with changes to fix the wrapping of strings.

    If you would like these string related checkpatch warnings fixed, I
    can look into creating a follow-on patch to fix those up. There are
    quite a few more instances in sdhci.c that wouldn't get addressed if I
    simply fixed up my existing patch. And that would be the other
    argument against intermixing 2 different fixes: I wouldn't be taking
    care of all string wrapping issues if I just fixed the four instances
    it complains about in my patch.

    Some of those wrapped strings are actually quite long. Here's an example:

    https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/mmc/host/sdhci.c?id=refs/tags/v3.16-rc1#n1938

    So, fixing those long messages may take a bit more thought than one
    might initially expect.

    Please let me know how you would like to proceed.

    Thanks,
    -Markus


    \
     
     \ /
      Last update: 2014-06-16 19:21    [W:4.674 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site