lkml.org 
[lkml]   [2014]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH tty-next 21/22] serial: core: Remove superfluous ldisc flush from uart_close()
    Date
    The tty_ldisc_flush() after port hardware shutdown is unnecessary;
    the ldisc flush was just performed before the hardware shutdown
    in tty_port_close_start() and the ldisc will be released when
    uart_close() returns (because the last port close implies the
    last tty close).

    Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
    ---
    drivers/tty/serial/serial_core.c | 3 ---
    1 file changed, 3 deletions(-)

    diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
    index 212ee07..15212d7 100644
    --- a/drivers/tty/serial/serial_core.c
    +++ b/drivers/tty/serial/serial_core.c
    @@ -1351,9 +1351,6 @@ static void uart_close(struct tty_struct *tty, struct file *filp)

    mutex_lock(&port->mutex);
    uart_shutdown(tty, state);
    -
    - tty_ldisc_flush(tty);
    -
    tty_port_tty_set(port, NULL);
    tty->closing = 0;
    spin_lock_irqsave(&port->lock, flags);
    --
    2.0.0


    \
     
     \ /
      Last update: 2014-06-16 16:01    [W:4.411 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site