Messages in this thread | | | Date | Mon, 16 Jun 2014 14:18:31 +0900 | From | Joonsoo Kim <> | Subject | Re: [PATCH v2 01/10] DMA, CMA: clean-up log message |
| |
On Thu, Jun 12, 2014 at 11:53:16AM +0200, Michal Nazarewicz wrote: > On Thu, Jun 12 2014, Michal Nazarewicz <mina86@mina86.com> wrote: > > I used “function(arg1, arg2, …)” at the *beginning* of functions when > > the arguments passed to the function were included in the message. In > > all other cases I left it at just “function:” (or just no additional > > prefix). IMO that's a reasonable strategy. > > At closer inspection, I realised drivers/base/dma-contiguous.c is > Marek's code, but the above I think is still reasonable thing to do, so > I'd rather standardise on having “function(…)” only at the beginning of > a function. Just my 0.02 CHF.
Hello,
Now, I realize that these changes aren't needed in this patchset, so I simplify this patch just to remove redundant 'CMA' prefix. Other things can be done after merging if we need.
Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |