Messages in this thread | | | Date | Mon, 16 Jun 2014 00:16:30 +0200 | Subject | Re: [PATCH -next 25/26] fbdev: Use dma_zalloc_coherent | From | Geert Uytterhoeven <> |
| |
On Sun, Jun 15, 2014 at 10:37 PM, Joe Perches <joe@perches.com> wrote: > diff --git a/drivers/video/fbdev/da8xx-fb.c b/drivers/video/fbdev/da8xx-fb.c > index a8484f7..788f6b3 100644 > --- a/drivers/video/fbdev/da8xx-fb.c > +++ b/drivers/video/fbdev/da8xx-fb.c > @@ -1447,18 +1447,15 @@ static int fb_probe(struct platform_device *device) > da8xx_fb_fix.line_length - 1; > > /* allocate palette buffer */ > - par->v_palette_base = dma_alloc_coherent(NULL, > - PALETTE_SIZE, > - (resource_size_t *) > - &par->p_palette_base, > - GFP_KERNEL | GFP_DMA); > + par->v_palette_base = dma_zalloc_coherent(NULL, PALETTE_SIZE, > + (resource_size_t *)&par->p_palette_base,
Suggestion for further cleanup: It seems this cast is no longer needed.
> + GFP_KERNEL | GFP_DMA);
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |