Messages in this thread Patch in this message | | | Subject | Re: [PATCH] Coccinelle : Script to detect cast after memory allocation | From | Joe Perches <> | Date | Sat, 14 Jun 2014 13:03:37 -0700 |
| |
On Sun, 2014-06-15 at 01:03 +0530, Himangi Saraogi wrote: > Hi,
Hi Himangi.
> I have run the generic rule but it does not detect the cases of > cast where the k[mzc]alloc or the kmem functions are used. I have used > flags like recursive-includes, as suggested by Julia, but not any of the > cases covered by the original script are detected.
Odd.
When I tried it I got things like:
$ cat void.cocci @@ void *t; type other; @@
- (other *)t + t
$ spatch --version spatch version 1.0.0-rc14 without Python support and with PCRE support
$ spatch --sp-file void.cocci --recursive-includes drivers/block/cciss_scsi.c drivers/block/cciss_scsi.c +++ /tmp/cocci-output-8427-7875f0-cciss_scsi.c @@ -704,8 +704,7 @@ cciss_scsi_setup(ctlr_info_t *h) struct cciss_scsi_adapter_data_t * shba; ccissscsi[h->ctlr].ndevices = 0; - shba = (struct cciss_scsi_adapter_data_t *) - kmalloc(sizeof(*shba), GFP_KERNEL); + shba = kmalloc(sizeof(*shba), GFP_KERNEL); if (shba == NULL) return; shba->scsi_host = NULL;
| |