Messages in this thread | | | Date | Sat, 14 Jun 2014 09:41:19 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 0/2] make kASLR vs hibernation boot-time selectable |
| |
On 06/13/2014 05:39 PM, Rafael J. Wysocki wrote: > > -#define RESTORE_MAGIC 0x0123456789ABCDEFUL > +#define RESTORE_MAGIC 0x0123456789ABCDF0UL >
<bikeshed>
Please don't pick numbers like this for magic numbers... *everyone else does, too.* In general, picking a random number is a good starting point; for extra bonus make sure it has at least one invalid UTF-8 sequence in it (so it cannot be confused with either ASCII or UTF-8 text.)
</bikeshed>
-hpa
| |