Messages in this thread | | | From | Andy Lutomirski <> | Date | Fri, 13 Jun 2014 10:29:46 -0700 | Subject | Re: [PATCH] kbuild: Do not run modules_install and install in paralel |
| |
On Fri, Jun 13, 2014 at 2:45 AM, Michal Marek <mmarek@suse.cz> wrote: > Dne 13.6.2014 11:39, Michal Marek napsal(a): >> Based on a x86-only patch by Andy Lutomirski <luto@amacapital.net> >> >> With modular kernels, 'make install' is going to need the installed >> modules at some point to generate the initramfs. >> >> Signed-off-by: Michal Marek <mmarek@suse.cz> >> --- >> Makefile | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Makefile b/Makefile >> index 7680d7c..7e5e483 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -503,6 +503,12 @@ ifeq ($(KBUILD_EXTMOD),) >> endif >> endif >> endif >> +# install and module_install need also be processed one by one >> +ifneq ($(filter install,$(MAKECMDGOALS)),) >> + ifneq ($(filter modules_install,$(MAKECMDGOALS)),) >> + mixed-targets := 1 >> + endif >> +endif > > Note that this version does not enforce the ordering, it just avoids the > interleaved execution. It can be added if desired.
Hmm. This will fix 'make modules_install install' but will not fix 'make install modules_install'. I don't know how many people would type the latter.
--Andy
| |