lkml.org 
[lkml]   [2014]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 05/19] irqchip: crossbar: Change allocation logic by reversing search for free irqs
On Fri, Jun 13, 2014 at 11:39:39AM +0530, Sricharan R wrote:
> Hi Jason,
>
> On Thursday 12 June 2014 06:26 PM, Jason Cooper wrote:
> > On Thu, Jun 12, 2014 at 05:23:13PM +0530, Sricharan R wrote:
> >> From: Nishanth Menon <nm@ti.com>
> >>
> >> Reverse the search algorithm to ensure that address mapping and IRQ
> >> allocation logics are proper. This can open up new bugs which are
> >> easily fixable rather than wait till allocation logic approaches
> >> the limit to find new bugs.
> >
> > Could you expand on this logic some more? What class of bugs are you
> > hoping to discover more easily?
> >
>
> class 1. address space errors -> example:
> reg = <a size_b>
> ti,max-irqs = is a wrong parameter
>
> class 2: irq-reserved list - which decides which entries in the
> address space is not actually wired in
>
> class 3: wrong list of routable-irqs.
>
> in general allocating from max to min tends to have benefits in
> ensuring the different issues that may be present in dts is easily
> caught at definition time, rather than at a later point in time.

Perfect, thanks for clarifying. Please add this to the commit log when
you respin.

thx,

Jason.


\
 
 \ /
  Last update: 2014-06-13 16:01    [W:0.060 / U:9.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site