Messages in this thread | | | Date | Fri, 13 Jun 2014 11:30:04 +0300 | From | Roger Quadros <> | Subject | Re: [PATCH 18/36] ARM: OMAP2+: gpmc-onenand: Move Synchronous setting code to drivers/ |
| |
On 06/13/2014 10:55 AM, Tony Lindgren wrote: > * Roger Quadros <rogerq@ti.com> [140611 01:59]: >> Move the code that puts the onenand in synchronous mode >> into the appropriate place i.e. drivers/mtd/onenand/omap2.c. >> >> Make use of omap_gpmc_get_clk_period() and omap_gpmc_retime() >> to calculate the necessary timings and configure the GPMC >> parent's timings. > > Ideally we would just use the drivers/mtd/onenand/generic.c > and get rid of drivers/mtd/onenand/omap2.c. We still need > the bus glue, which should probably be in drivers/memory? >
But what about the runtime synchronous timing calculations onenand/omap2.c? There is also OMAP2 and OMAP3 specific dma handling done there, which should probably be done generically using dmaengine.
cheers, -roger
| |